Optional material design #255
Conversation
…ture/materialDesign
…ture/materialDesign
…ture/materialDesign # Conflicts: # client-data/material_board.css
|
Thank you for your PR ! However, I'm not sure WBO itself should contain multiple themes. Can we instead just have an Also, you can already create your own custom docker image taking I am happy to take contributions to the existing CSS, but I don't feel like maintaining multiple themes in the long term. |
|
So you have no problem when I overvrite your css with material design? |
|
The CSS should be coherent in the homepage and in the boards, but that's all. I am open to PRs that change in the CSS for the board page. |
|
I changed the original css to material design. |
client-data/board.css
Outdated
| url('fonts/roboto-v30-latin-regular.eot?#iefix') format('embedded-opentype'), /* IE6-IE8 */ | ||
| url('fonts/roboto-v30-latin-regular.woff2') format('woff2'), /* Super Modern Browsers */ | ||
| url('fonts/roboto-v30-latin-regular.woff') format('woff'), /* Modern Browsers */ | ||
| url('fonts/roboto-v30-latin-regular.ttf') format('truetype'), /* Safari, Android, iOS */ | ||
| url('fonts/roboto-v30-latin-regular.svg#Roboto') format('svg'); /* Legacy iOS */ |
There was a problem hiding this comment.
I'd like to avoid embedding large blobs in this repo.
Can we use system fonts ?
There was a problem hiding this comment.
Unfortunentally Roboto is only possible as extra font.
But Arial almost looks like the same. We could also use Roboto directly from google, but this I want to avoid because then we are not independent.
But I think deliver a font is like the images we have in the repo. It`s not unusal to deliver the correct font in a software project.
There was a problem hiding this comment.
I just took a look. the size is only ~90kb
There was a problem hiding this comment.
Can we just use the system's default ? On the frontend wejust use
font-family: sans-serif;
font-weight: 300;which I think looks decent and well-integrated everywhere.
README.md
Outdated
| ## Themeing | ||
|
|
||
| it is posible to choose between different themes. Up to now only the __default__ and __material__ theme is supported. | ||
|
|
||
| To choose the material theme add | ||
|
|
||
| `THEME_OPTIONS=material` |
|
removed the roboto extra fonts |
server/configuration.js
Outdated
| /** Theme options e.g. material */ | ||
| THEME_OPTIONS: (process.env["THEME_OPTIONS"] || ""), | ||
|
|
client-data/index.css
Outdated
| @font-face { | ||
| font-family: 'Roboto'; | ||
| font-style: normal; | ||
| font-weight: 400; | ||
| src: url('fonts/roboto-v30-latin-regular.eot'); /* IE9 Compat Modes */ | ||
| src: local(''), | ||
| url('fonts/roboto-v30-latin-regular.eot?#iefix') format('embedded-opentype'), /* IE6-IE8 */ | ||
| url('fonts/roboto-v30-latin-regular.woff2') format('woff2'), /* Super Modern Browsers */ | ||
| url('fonts/roboto-v30-latin-regular.woff') format('woff'), /* Modern Browsers */ | ||
| url('fonts/roboto-v30-latin-regular.ttf') format('truetype'), /* Safari, Android, iOS */ | ||
| url('fonts/roboto-v30-latin-regular.svg#Roboto') format('svg'); /* Legacy iOS */ | ||
| } |
There was a problem hiding this comment.
We need to remove that too don't we ?
|
Hello @lovasoa, will you merge the PR in the future? Best regards |
|
Hello @lovasoa, |
I created the possibility to theme the board with material Design.
For this I create a new env variable: THEME_OPTIONS. this can be set to material.
Then a new css with material design is added.
Also Roboto is included as font.