Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show checkbox on newly attached MBID too #27

Closed
wants to merge 0 commits into from
Closed

Show checkbox on newly attached MBID too #27

wants to merge 0 commits into from

Conversation

jesus2099
Copy link
Contributor

Newly attached MBID appear as <td><i><a...>Recording MBID</a></i></td> instead of <td><a...>Recording Title</a></td>.

For some reason they were excluded from script.

I include them as one may need to merge those new recordings too.

Like here: https://acoustid.org/track/64422fbb-b0ec-426b-9c00-31118754944b

But maybe there are other legitimate cases where those MBID-only recordings should be excluded?
I don't use AcoustID much, please tell me.
I think it's only when they are disabled too, which is still covered by your if (!tr.classList.contains('mbid-disabled')).

@jesus2099
Copy link
Contributor Author

jesus2099 commented Dec 7, 2020

Oh I see why you did not show checkbox for italic MBID.

They don't always mean brand new recordings, they also often mean merged away recordings like https://acoustid.org/track/fc1a542d-4c52-43dd-9aab-e06173e40c10 where both grows are now the same merged recording.
I think I will add a check if only one recording fix ID found, to not launch the merge, because it will not work.

@loujine
Copy link
Owner

loujine commented Dec 29, 2020

I thought links appearing as mbids were always obsolete, so I excluded them from merging. If you find a solution to ditinguish from new mbids, no problem to merge this PR of course.

@jesus2099 jesus2099 closed this Mar 16, 2021
@jesus2099
Copy link
Contributor Author

Whoops, I closed this one by force pushing master branch for #33.
I don't mind that much.

@loujine loujine mentioned this pull request Jun 30, 2020
@jesus2099
Copy link
Contributor Author

jesus2099 commented Nov 7, 2023

I see more often MBID that I do need to merge rather than MBID that just redirect to a merged recording.

Probably because AcoustID server is often late, nowadays.

I think it should be benefical to reenable this.
Because even in the case where MBID is just a merged recording, it does not harm much (it will just redirect to another recording)...

It would be nice to distinguish them, though... it would require to call them each and see if MBID redirects or not...

@jesus2099
Copy link
Contributor Author

I made a new version: #113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants