Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fetch info and change buttons for MBID only recordings #113

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

feat: fetch info and change buttons for MBID only recordings #113

wants to merge 2 commits into from

Conversation

jesus2099
Copy link
Contributor

@jesus2099 jesus2099 commented Dec 2, 2024 •
edited
Loading

Merged recording (when the merged recording is also in the table)

  • move below merged recording
  • remove checkbox and disable/enable button

Merged recording (when the merged recording is not in the table)

  • display recording title and artist credits
  • remove checkbox and disable/enable button

Deleted recording

  • mark red
  • remove checkbox and disable/enable button maybe I should keep disable button but I don’t know if the case happens

@jesus2099
feat: fetch info and change buttons for MBID only recordings
060e34d 
Merged recording (target is visible in page)
----------------

- move below target
- remove checkbox and disable/enable button


Merged recording (target is not visible in page)
----------------

- display recording title and artist credits
- remove checkbox and disable/enable button


Deleted recording
-----------------

- mark red
- remove checkbox and disable/enable button
  maybe I should keep disable button
  but I don’t know if the case happens
@jesus2099
Copy link
Contributor Author

jesus2099 commented Dec 2, 2024 •
edited
Loading

It's a new version of #27.

image
image

I tested on https://acoustid.org/track/1865c595-8384-4c60-9f99-7fae6c4229e8?disabled=1 but I need more testing.
I would like to find a deleted recording, still linked to an AcoustID, for example, if it exists.

@jesus2099 jesus2099 mentioned this pull request Dec 2, 2024
Closed
@jesus2099
Copy link
Contributor Author

jesus2099 commented Dec 2, 2024 •
edited
Loading

I tried to follow your coding style, but I will fix the remaining eslint issues with a final commit.

@jesus2099
Copy link
Contributor Author

jesus2099 commented Dec 2, 2024 •
edited
Loading

@loujine I found two examples of deleted recordings with AcoustID still linked.
Should I keep the Disable button, so that someone wanting to cleanup could do it?

Also, for merged recordings, I currently display them below their target but in reverse order.
Maybe I should preserve order as it was in the AcoustID page, maybe it has a meaning like oldest first?

@jesus2099
Copy link
Contributor Author

I made a web service version but it seems I'm hitting the rate limit, now...

Another interesting URL: https://acoustid.org/track/a4b0d791-444d-4f50-9431-7479a292640d?disabled=1

@jesus2099 jesus2099 marked this pull request as draft December 2, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jesus2099