Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind Mount Volume Translated Incorrectly From Docker Run #195

Open
2 tasks done
MeCJay12 opened this issue Nov 27, 2023 · 2 comments
Open
2 tasks done

Bind Mount Volume Translated Incorrectly From Docker Run #195

MeCJay12 opened this issue Nov 27, 2023 · 2 comments
Labels

Comments

@MeCJay12
Copy link

⚠️ Please verify that this bug has NOT been reported before.

  • I checked and didn't find similar issue

🛡️ Security Policy

Description

From the home page, this docker run command was entered into the converstion tool:

docker run -d \
	--restart=always \
	--network better_bridge \
	--name YTDL \
	--mount type=bind,src=/mnt/Data/Seeding/_YTDL/,dst=/downloads \
	alexta69/metube

This was the output when trying to deploy the stack:

Dockge

It seems like src and dst are incorrect and I was able to fix it by chnaging to source and target respectively.

👟 Reproduction steps

From the home page, enter this docker run command into the converstion tool:

docker run -d \
	--restart=always \
	--network better_bridge \
	--name YTDL \
	--mount type=bind,src=/mnt/Data/Seeding/_YTDL/,dst=/downloads \
	alexta69/metube

👀 Expected behavior

The next Deploy button should launch the container successfully.

😓 Actual Behavior

Dockge

Dockge Version

1.2.0

💻 Operating System and Arch

Ubuntu 22.04 x64

🌐 Browser

Chrome 119.0.6045.160 (Official Build) (64-bit)

🐋 Docker Version

No response

🟩 NodeJS Version

Docker version 24.0.5, build 24.0.5-0ubuntu1~22.04.1

📝 Relevant log output

No response

@MeCJay12 MeCJay12 added the bug Something isn't working label Nov 27, 2023
@louislam
Copy link
Owner

    volumes:
      - type: volume
        source: db-data
        target: /data

The correct one should be this. Will transfer the issue to https://github.com/composerize/composerize

@MeCJay12
Copy link
Author

I noticed that if I set the type to volume it would not work at all in this form. I had to use the src:dst format for volume type volumes.

Wouldn't work
    volumes:
      - type: volume
        source: db-data
        target: /data
Works
    volumes:
      - db-data:/data

image

I'm opened this bug for

Generated
    volumes:
      - type: bind
        src: db-data
        dst: /data
Working
    volumes:
      - type: bind
        source: db-data
        target: /data

A little later on I found that bind mounts that are read only also convert wrong. I can open a new bug for it but I think it would be easy to fix at once. They come through as readonly: null when they should be read_only: true.

Input
    docker run -d \
	--restart always \
	--network better_bridge \
	--name Ubooquity \
	--mount type=bind,src=/mnt/Docker/Ubooquity,dst=/config \
	--mount type=bind,src=/mnt/Data/Books/,dst=/books,readonly \
	-e TZ=America/New_York \
	linuxserver/ubooquity
Generated
    volumes:
      - type: bind
        src: /mnt/Data/Books/
        dst: /books
        readonly: null
Functional
    volumes:
      - type: bind
        src: /mnt/Data/Books/
        dst: /books
        read_only: true

@louislam louislam removed the bug Something isn't working label Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants