Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Make the GUI an optional cargo feature #159

Open
benjamin051000 opened this issue Jan 4, 2025 · 2 comments
Open

[FEATURE] Make the GUI an optional cargo feature #159

benjamin051000 opened this issue Jan 4, 2025 · 2 comments
Labels
feature Feature request

Comments

@benjamin051000
Copy link
Contributor

There are two ways to interact with Arnis: The GUI and the CLI.

The GUI is nice, and is the default way to interact with the project. However, I honestly prefer the CLI, and I'm sure others do, too. #linuxuser

It would be nice if I could strip out the GUI components for faster compile times/reduced dependencies. I believe the Rust way of doing this is by making CLI and GUI "features" in Cargo.toml?

I still think the GUI should be the default, but you could perhaps make it possible to disable it and get only the CLI.

That way I don't have to compile like 800 deps and can have a slim version of the app. :D

Also, there could be a way to strip out the CLI and just have the GUI, although I'm not sure how much compile/space savings that would offer since the CLI is pretty simple.

@benjamin051000 benjamin051000 added the feature Feature request label Jan 4, 2025
@louis-e
Copy link
Owner

louis-e commented Jan 4, 2025

The CLI mode was originally even the standard interface, it's still in the code! Just remove this line which suppresses it:

#![cfg_attr(not(debug_assertions), windows_subsystem = "windows")]

And run it as follows: arnis --path="C:/YOUR_PATH/.minecraft/saves/worldname" --bbox="min_lng,min_lat,max_lng,max_lat"

We're currently discussing in #99 if we really want to keep the command line interface. And if so, how we should make it available on Github. I agree with you, it'd be cool to have a stripped down version with just the CLI - especially for making the compilation a bit easier on Linux. However I'm not sure yet how to do it while keeping an easy maintainability

@benjamin051000
Copy link
Contributor Author

I mean, it's definitely not a deal-breaker. Just a nice-to-have. If only 1% of users want a command line, it may not be worth the effort. 🤷🏼‍♂️ Feel free to focus on other efforts in the mean-time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature request
Projects
None yet
Development

No branches or pull requests

2 participants