Search improvements #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f player, encounter and class names
|
I think something here is bugged |
|
Never mind it works, i just had old files from a previous test still in the folder |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to search using AND combined player, class and encounter names.
For this feature I need to add information about players to the parsed session files.
The information will be pulled from the _encounter.json files into the session json files the next time the use visits the Logs tab.
For my ~17GB of parsed Logs (15532 files) this upgrade process took about 4min 30s on a built version (in debugger it took considerably longer). This time might vary a lot, depending on disk/cpu speed through.