Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(authorization): legacy "extract common layer" notice #4196

Closed
achrinza opened this issue Nov 23, 2019 · 3 comments
Closed

docs(authorization): legacy "extract common layer" notice #4196

achrinza opened this issue Nov 23, 2019 · 3 comments
Assignees
@deepakrkris
Labels
bug Docs

Comments

@achrinza
Copy link
Member

achrinza commented Nov 23, 2019 •
edited
Loading

Steps to reproduce

  1. Go to @loopback/authorization README

  2. Read "Extract Common Layer (TBD)" section

    image

Current Behavior

This section exists, stating that the common interfaces are being refactored into the @loopback/security package and suggesting workarounds as it assumes that the refactoring has not been completed.

Expected Behavior

This section should not exist or be updated to reflect the current status.

@loopback/security has been published and #2900 has been merged for a while. Furthermore, @loopback/authentication README has references to use @loopback/security since v3.0.0. In addition, the referenced draft branch hasn't had a commit in 6 months and the referred PR has been merged. It seems safe to assume that the section is outdated.

@loopback/authentication README

image

Link to reproduction sandbox

N/A

Additional information

N/A

Related Issues

N/A
@achrinza achrinza added the bug label Nov 23, 2019
@achrinza achrinza changed the title docs(security): legacy "extract commo layer" notice docs(security): legacy "extract common layer" notice Nov 23, 2019
@dhmlau dhmlau added the Docs label Nov 23, 2019
@dhmlau
Copy link
Member

dhmlau commented Nov 23, 2019

cc @deepakrkris @jannyHou.
Not sure if it'll be covered in #3694, but something to keep in mind. Thanks.

@achrinza achrinza changed the title docs(security): legacy "extract common layer" notice docs(authorization): legacy "extract common layer" notice Nov 25, 2019
@deepakrkris
Copy link
Contributor

currently addressed in PR , #4185

@deepakrkris
Copy link
Contributor

PR merged, closing issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deepakrkris deepakrkris

Labels
bug Docs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@deepakrkris @achrinza @dhmlau