Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] create helper function ignores the id property when it's equal to 0. #1968

Open
sachinibm2 opened this issue Jul 27, 2022 · 0 comments
Labels

Comments

@sachinibm2
Copy link

sachinibm2 commented Jul 27, 2022

Description :
Create call on a loopback model returns a property id as a response, in case where the property id starts from 0 it is removed from response. This is because the create function( dao.js line no 378) which gets the id as a callback on the create call in a loopback model, does not accepts 0 as an id.

Code snippet from dao.js
if id is 0 it is skipping the if block

function createCallback(err, id, rev) {          
if (id) {
  obj.__data[_idName] = id;
   defineReadonlyProp(obj, _idName, id);
}

We have a scenario where the id starts from 0, and this is causing the id property for our 0th element to be removed from the response.

Steps to reproduce :

  • Model which has a property id which starts from 0.
  • Call the api to create which will have the id (starting from 0) in response.
  • Response will be missing the id property for the first call where id is 0, and it'll add the id property in response starting from id as 1 onwards.

Current Response Behaviour :
id is removed when its value is equal to 0

{
    "property1" : "property1",
   "property2" : "property2"
}

Expected Results :

{
    "id" : 0
    "property1" : "property1",
    "property2" : "property2"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Icebox
Development

No branches or pull requests

1 participant