Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MongoDB.prototype.getDefaultIdType #600

Closed
2 tasks
hacksparrow opened this issue Sep 25, 2020 · 2 comments
Closed
2 tasks

Remove MongoDB.prototype.getDefaultIdType #600

hacksparrow opened this issue Sep 25, 2020 · 2 comments

Comments

@hacksparrow
Copy link
Contributor

hacksparrow commented Sep 25, 2020

Follow up of loopbackio/loopback-next#3456.

As a precursor to #598, remove MongoDB.prototype.getDefaultIdType.

Tips: Consider return string instead of removing it which causes confusion. Add comments explain why we return string in mongodb connector.

  • Update the function.
  • Update and fix tests as well.
@stale
Copy link

stale bot commented Jul 14, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 14, 2021
@stale
Copy link

stale bot commented Jul 28, 2021

This issue has been closed due to continued inactivity. Thank you for your understanding. If you believe this to be in error, please contact one of the code owners, listed in the CODEOWNERS file at the top-level of this repository.

@stale stale bot closed this as completed Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants