Skip to content
This repository has been archived by the owner on Jan 22, 2021. It is now read-only.

shortcode requires leading space? #4

Open
timmyg opened this issue Jun 14, 2016 · 5 comments
Open

shortcode requires leading space? #4

timmyg opened this issue Jun 14, 2016 · 5 comments

Comments

@timmyg
Copy link

timmyg commented Jun 14, 2016

doesn't convert:

hey how are you:blush:

converts properly:

hey how are you :blush:

Any thoughts on how to handle this scenario? Didnt see anything in docs. Thanks!

@johanbrook
Copy link
Contributor

Hi! It's currently not handled, but I can see the use case. PR is welcomed :)

@timmyg
Copy link
Author

timmyg commented Jun 14, 2016

OK. What are your thoughts on best way to implement?

On Tue, Jun 14, 2016, 11:37 AM Johan Brook [email protected] wrote:

Hi! It's currently not handled, but I can see the use case. PR is welcomed
:)


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#4 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABF1srjgXMiOnC9XK08eaijo0Jnd_gdiks5qLsq8gaJpZM4I1cxt
.

@johanbrook
Copy link
Contributor

Probably tweaking the regex in here: https://github.com/lookback/meteor-emoji/blob/master/emojis.coffee#L3, but it'll be tricky, since we don't want it to parse things like http:// and make :/ into a smiley emoji. See my comment in the code.

Generally, I don't know if this is worth fixing.

@littke
Copy link

littke commented Jun 20, 2016

Slack doesn't support this either, just FYI. Maybe by design.

@johanbrook
Copy link
Contributor

johanbrook commented Jun 20, 2016

Probably.

(Test: foo:fire: )

Ok, GitHub handles it:

(Test: foo:fire: )

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

3 participants