Skip to content
This repository has been archived by the owner on Jan 22, 2021. It is now read-only.

How to handle unicode strings & lowercase letters not able to detect in ascii field #3

Open
dominicarrojado opened this issue Feb 8, 2016 · 8 comments

Comments

@dominicarrojado
Copy link

I force the Emoji to turn into image but now what If user paste a 😀 which is a unicode?

@dominicarrojado
Copy link
Author

Cannot detect small laters on ascii I tried to put ':p' in the ascii but its able to detect capitalize ":P" and some letters even capitalize not working also.

@dominicarrojado dominicarrojado changed the title How to handle unicode strings? How to handle unicode strings & lowercase letters not able to detect in ascii field Feb 8, 2016
@dominicarrojado
Copy link
Author

@johanbrook

@johanbrook
Copy link
Contributor

This should perhaps be two issues?

  • Anyway, I think we should go with capitalized ASCII emojis. Otherwise, :d would be a :D, which looks funny.
  • It's been out of scope for this package to parse Unicode emojis. Happy to look at a PR for that though.

@dominicarrojado
Copy link
Author

Thanks for the reply man! @johanbrook Yea probably right about sticking to capitalized I'm just used to entering :p. But the issue tho some ascii's not working. Like you defined this ascii :') but its not able to find the emoji and also trying other letters doesn't work also like capital L for example.

Ok not a big deal in the second one. Hope somebody PR haha.

@dominicarrojado
Copy link
Author

@johanbrook btw loving the package. So easy to use and customize

@johanbrook
Copy link
Contributor

Thank you!

Are you sure :') isn't parsed? The tests for it go through: https://github.com/lookback/meteor-emoji/blob/master/spec/emojis-spec.coffee#L63-L71

@dominicarrojado
Copy link
Author

Yeah. :* not working also. Btw I forced all to use images. I tried both {{#emoji}}{{/emoji}} and the javascript Emojis.parse(text). Still doesn't parse. Later I'll try not forcing to use images if it still doesn't parse.

@dominicarrojado
Copy link
Author

OK I figured why :') is not being parsed cause I escaped it with an HTML escape script. But :* still doesn't work after removing all my parsers. Just the plain message.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants