Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor shutdown sequence to use plugin.stop #6

Closed
Tracked by #3963
jsvd opened this issue Sep 11, 2015 · 2 comments
Closed
Tracked by #3963

refactor shutdown sequence to use plugin.stop #6

jsvd opened this issue Sep 11, 2015 · 2 comments
Assignees
@jsvd

Comments

@jsvd
Copy link
Member

jsvd commented Sep 11, 2015

Change shutdown sequence to be triggered by plugin.stop instead of ShutdownSignal exception.
Also remove any calls to: shutdown, finished, finished?, running? or terminating?
This depends on elastic/logstash#3895
@jsvd jsvd mentioned this issue Sep 11, 2015
Closed
43 tasks
@jsvd jsvd self-assigned this Sep 11, 2015
@jsvd jsvd mentioned this issue Sep 24, 2015
Open
53 tasks
@gjelu
Copy link

gjelu commented Dec 29, 2016

I have created a fork and refactored it: gjelu@e8207dd

added calls to stop, close, stop?
removed ShutdownSignal exception
make use of the new Event API (get, set), see issue #14

AgentW4C added a commit to AgentW4C/logstash-input-jms that referenced this issue Feb 3, 2017
@AgentW4C
Fix issue logstash-plugins#6 - use missing calls from Plugin API - st…
75ad3bd 
…op, close, stop?
AgentW4C added a commit that referenced this issue Feb 3, 2017
@AgentW4C
Merge pull request #15 from JiriKadlcik/#6_refactor_shutdown_sequence
7ee3df2 
Fix issue #6 - use missing calls from Plugin API - stop, close, stop?
@AgentW4C
Copy link
Collaborator

AgentW4C commented Feb 3, 2017

Used gjelu's commit and and merged as #15

@AgentW4C AgentW4C closed this as completed Feb 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsvd jsvd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jsvd @suyograo @AgentW4C @gjelu