Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop the jruby-jms dependency (to avoid Ruby warnings) #50

Open
kares opened this issue Nov 2, 2021 · 1 comment
Open

drop the jruby-jms dependency (to avoid Ruby warnings) #50

kares opened this issue Nov 2, 2021 · 1 comment
Labels

Comments

@kares
Copy link
Contributor

kares commented Nov 2, 2021

jruby-jms repo has been archived by the owner, which means we can not submit patches or report issues upstream (technically issues can be submitted but won't get fixed).

there's Fixnum/Bignum warnings at the library level that are annoying and should be dealt with:
reidmorrison/jruby-jms@master...kares:patch-1

there's a few options forward:

  • vendor the jruby-jms gem, in the plugin, and drop the dependency
  • fork the gem under a new name and start using that as a dependency
  • drop the dependency completely and use the Java API directly

first option might be the easiest to take for the foreseeable future ...

@kares kares added the bug label Nov 2, 2021
@jsvd
Copy link
Member

jsvd commented Nov 2, 2021

I'm tempted to go for option 1 (vendoring) with a caveat: we should merge the JMS input and output into the logstash-integration-jms. This way we don't have to vendor the code into two repositories and duplicate any work we do to this library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants