Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The UI stores should only necessary values needed for rendering #388

Open
vojtechsimetka opened this issue Apr 4, 2023 · 0 comments
Open

The UI stores should only necessary values needed for rendering #388

vojtechsimetka opened this issue Apr 4, 2023 · 0 comments
Assignees
@vojtechsimetka
Labels
enhancement New feature or request

Comments

@vojtechsimetka
Copy link
Contributor

For example the profile store should not know about signer. That is job of the adapter to manage. Instead all asserts should check if there is address in profile.

This will clean up a lot of confusing code asserting signer.
@vojtechsimetka vojtechsimetka added the enhancement New feature or request label Apr 4, 2023
@vojtechsimetka vojtechsimetka self-assigned this Apr 4, 2023
@vojtechsimetka vojtechsimetka changed the title The UI stores should only know values needed for rendering The UI stores should only necessary values needed for rendering Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vojtechsimetka vojtechsimetka

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vojtechsimetka