Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No topic selected error not handled in data_loader_widget #14

Open
romainreignier opened this issue Apr 30, 2020 · 0 comments
Open

No topic selected error not handled in data_loader_widget #14

romainreignier opened this issue Apr 30, 2020 · 0 comments
Labels
good first issue Good for newcomers

Comments

@romainreignier
Copy link
Contributor

romainreignier commented Apr 30, 2020

If one does not select a topic, the selected row is -1 and the .text() throws an exception here:

row = self.tableWidget.currentRow()
topicName = self.tableWidget.item(row, 0).text()

There should be a check if row == -1 or catch the exception.

For now, the Add Layer button stays disabled and with the Loading... text on the bag dialog.

I am not a Python developer so I am not sure how to best catch the error.

@ablakey ablakey added the good first issue Good for newcomers label Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants