Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install space script shouldn't be reliant on the current system's absolute path #104

Open
AnonymousRoboticist opened this issue Jul 10, 2023 · 1 comment

Comments

@AnonymousRoboticist
Copy link

AnonymousRoboticist commented Jul 10, 2023

Unless my understanding is off, the catkin install space is supposed to be thought of as for deployment purposes. catkin-virtual-env seems to create a script that has absolute paths embedded in it. Anonymised output from version 0.6.1:

#!/usr/bin/env bash
exec /home/USER/WS/install/share/PACKAGE/venv/bin/python /home/USER/WS/install/share/PACKAGE/catkin_virtualenv_scripts/SCRIPT "$@"

This will break if your ROS deployment's install space is isn't in the exact same path with the same username. I had a look and there doesn't seem to have been any changes that would fix this since 0.6.1 and I can't see any options to fix this. #63 seems to have fixed a similar issue in different contexts.

The alternative is catkin_install_python creating a script that figures out where it itself is and uses relative paths to find the venv and true script (which is probably possible with some ROS environment variables (e.g. packages can be installed and found by ROS in any directory listed in ROS_PACKAGE_PATH) or one of the find-own-path bash commands.

@PFGrony
Copy link

PFGrony commented Sep 9, 2024

@AnonymousRoboticist Did you find a solution to this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants