Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce monorepo footprint #881

Closed
2 of 5 tasks
jondot opened this issue Oct 20, 2024 · 3 comments
Closed
2 of 5 tasks

reduce monorepo footprint #881

jondot opened this issue Oct 20, 2024 · 3 comments
Milestone

Comments

@jondot
Copy link
Contributor

jondot commented Oct 20, 2024

In order to make build folder take less space, and to ease up on rust-analyzer, we'd like to

  • Move loco-cli to its own independent repo (this was part of the plan until it stabilizes)
  • Move or remove macros, this was an experimental project that did not take off
  • Move loco-extras to its own repo, make sure that we still have interconnectedness between loco and loco-extras in terms of breakages
  • refactor + simplify xtask bump version process xtask: new bump versions #893
  • add a 'publish' step for subcrates, then main crate via xtask
@jondot jondot added this to the 0.12.0 milestone Oct 20, 2024
@joshka
Copy link
Contributor

joshka commented Oct 20, 2024

I really like that you have a mono-repo - it's a plus when you can just make changes and have them coherent with the rest of the repo. This is fairly small project all things considered - larger by at least two orders of magnitude git repos are still good for monorepos IMHO.

What's the problem with r-a that you're hitting?

@jondot
Copy link
Contributor Author

jondot commented Oct 22, 2024

@joshka you're right, better to keep a monorepo. right now i'm hitting a couple of limits:

  • target/ folder size can reach 10-40GB on occasions
  • rust-analyzer becomes sluggish as we're growing the list of members in the workspace

nevertheless, I've just added a subcrate: loco-gen because I had no other choice. For this instance, loco-gen will be the home of all things generators, including -- and more importantly -- generator testing, and generator testing was so heavy and filled with side-effects I had to isolate it in the form of a separate crate.

so looks like we're going to grow the amount of crates in the workspace any way, but then we'll remove some unneeded ones.

@jondot
Copy link
Contributor Author

jondot commented Oct 27, 2024

@jondot jondot closed this as completed Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants