Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Issues on the Generated HTMX/HTML Edit Scaffold #691

Closed
not4rt opened this issue Aug 8, 2024 · 1 comment
Closed

Minor Issues on the Generated HTMX/HTML Edit Scaffold #691

not4rt opened this issue Aug 8, 2024 · 1 comment

Comments

@not4rt
Copy link
Contributor

not4rt commented Aug 8, 2024

Description

The HTML of the edit page generated from an HTMX scaffold has two minor issues:

  1. The div tag of the button group is not closed (templates/scaffold/htmx/view_edit - Line 51)
  2. The checkboxes generated from boolean fields are not in sync with the item field (templates/scaffold/htmx/view_edit - Lines 33 and 35)

To Reproduce

  1. In an existing project, generate an HTMX scaffold with boolean fields, for example:
cargo loco generate scaffold movies name:string active:bool --kind htmx
  1. Open the generated edit html (assets\views\movies\edit.html)
  2. Format the document
  3. Check line 22 ("item.0" instead of "item.active") and 25 (open div tag)
    image

Expected Behavior

The checkboxes representing boolean fields should be in sync with the data.

Environment:
All?

@not4rt
Copy link
Contributor Author

not4rt commented Aug 11, 2024

Fixed at #692

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant