New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the parameters #40

Open

MaximilienNaveau opened this issue Nov 25, 2024 · 0 comments

Collaborator

MaximilienNaveau commented Nov 25, 2024

Wouldn't it make more sense to do it as this?

  __map_moving_joint_names: {
    p: {
      type: double,
      description: "Proportional gains for the PD controller.",
      validation: { gt_eq<>: 0.0 }
    }
    d: {
      type: double,
      description: "Derivation gains for the PD controller.",
      validation: { gt_eq<>: 0.0 }
    }
  }

Originally posted by @Kotochleb in #39 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment