Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mock_redis_client.from_url has incorrect signature #131

Open
beamerblvd opened this issue Oct 30, 2017 · 1 comment
Open

mock_redis_client.from_url has incorrect signature #131

beamerblvd opened this issue Oct 30, 2017 · 1 comment

Comments

@beamerblvd
Copy link

The signature of redis.Redis.from_url is as follows:

def from_url(cls, url, db=None, **kwargs)

However, Mockredispy defines it as follows:

def mock_redis_client(**kwargs):
    return MockRedis()

mock_redis_client.from_url = mock_redis_client

If redis.Redis.from_url is called with the valid arguments redis.Redis.from_url(url, **kwargs), it results in an error from Mockredispy about too many arguments passed to mock_redis_client.

@beamerblvd
Copy link
Author

Submitted pull request #133.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant