Change the tests to use require --dev

[andybroomfield]

Currently the tests install the composer suggest dependencies, but should really use the dev dependencies that are needed to run the tests, so we make sure that the correct dependencies are added to require-dev.

[millnut]

Hi @stephen-cox this also might be the same reason https://github.com/localgovdrupal/localgov_project/actions/runs/6402689252/job/17379803668 tests are now failing as it's not installing the group require-dev dependency of alert banner

[finnlewis]

I'm trying to understand why this happens.

When we run:

composer create-project --stability dev localgovdrupal/localgov-project:2.x-dev ./html

Do we expect composer to install the require-dev dependencies of all child packages?

Locally it does not seem to do so. I do not have group module for example which is now in require-dev.

https://github.com/localgovdrupal/localgov_alert_banner/blob/1.x/composer.json#L13

Might it be that composer only installs the require-dev from the root composer.json?

[finnlewis]

Sounds like that is what happens.

Composer only ever installs the packages listed as "require-dev" of your main composer.json file, and if these packages do need something else, then only their "require" packages are installed, but not their "require-dev" packages.

From https://stackoverflow.com/questions/21154216/composer-wont-install-require-dev-packages#:~:text=2%20Answers&text=Composer%20only%20ever%20installs%20the,actually%20is%20a%20good%20thing.

[millnut]

@finnlewis does that mean that for this module and any others we need to add them as a require-dev dependency to the root composer.json for the project?