-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can we display the banner by default without javascript? #125
Comments
@markconroy mentioned putting the block in tag with display block. This would then render it Javascript is disabled. |
@finnlewis @andybroomfield Yes, we had a similar issue recently and our solution was like this:
in the template. |
+1 for hiding banners server side since it would also remove the dependency on CSS to hide the banner. At the moment a hidden banner is still present in the HTML on subsequent page loads, and will be shown / announced to users if CSS is not available for any reason, or run the risk of a FOUC. At the least we should add |
Within the new theme we have a .no-js class that is present on initial load but removed straighaway by JS. We could use something like I like @danchamp idea of doing this server side if possible. |
Currently the banner requires javascript to display.
This is so that if a user has hidden the banner, there isn't a flash of the banner appearing breifly, as the logic to hide the banner is in javascript.
Is it possible to reverse this and have it so the banner is displayed by default and hidden server side?
I think the problem before was when the internal page caching module was turned on.
The text was updated successfully, but these errors were encountered: