Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bool for shim returns #58

Open
schteve opened this issue Mar 22, 2023 · 0 comments
Open

Use bool for shim returns #58

schteve opened this issue Mar 22, 2023 · 0 comments

Comments

@schteve
Copy link
Collaborator

schteve commented Mar 22, 2023

The existing code in the shim layer returns 0 or 1 as a proxy for a boolean. I wonder if there's opportunity to change those to bool. It seems based on this PR that bool is effectively the FFI type for itself, which is why there's nothing in ffi for it. I'm not 100% sure, but I'm having a hard time imagining a situation where this could cause any problems. Although, on second glance the 0 and 1 values are (at least sometimes) reversed - where 0 means success and 1 means failure. So we'd have to be careful to get the logic correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant