Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relative callback URL #134

Open
TheBlueMatt opened this issue Nov 26, 2021 · 3 comments
Open

Relative callback URL #134

TheBlueMatt opened this issue Nov 26, 2021 · 3 comments

Comments

@TheBlueMatt
Copy link

The callback url in payRequest makes it impossible to create a static implementation of a payRequest server - the server must know its full URI to return in the callback parameter. It would be nice to be able to specify at least server-relative callback URLs so that a static implementation (run behind NGINX or some other TLS proxy) could be built that doesn't need additional LNURL-specific configuration

@fiatjaf
Copy link
Collaborator

fiatjaf commented Nov 26, 2021

I agree.

@fiatjaf
Copy link
Collaborator

fiatjaf commented Nov 27, 2021

Even though I agree and think it was a design mistake to require full URLs, in most cases you can get away with that on the server side by reading Host, X-Forwarded-Host and all the other million special headers HTTP tools have for these purposes and then rebuilding the original URL of the first request.

@hsjoberg
Copy link
Collaborator

I agree, this would be great for easing Lightning Address deployment.

It sounds like it would be backwards incompatible for most if not all wallet implementations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants