Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: --only-binary :all: should be set when locking environments #102

Open
ncoghlan opened this issue Dec 18, 2024 · 1 comment
Open

Bug: --only-binary :all: should be set when locking environments #102

ncoghlan opened this issue Dec 18, 2024 · 1 comment
Labels
Category: Bug Something isn't working

Comments

@ncoghlan
Copy link
Collaborator

--only-binary :all: is currently being passed to pip install when building environments, but it isn't being passed to uv pip compile when locking environments. This allows an invalid lock file to be generated that depends on source archives that the environment building step will fail to install.

This option should be added to the set of common pip arguments defined by PackageIndexConfig rather than being set in the individual CLI invocations.

@ncoghlan ncoghlan added the Category: Bug Something isn't working label Dec 18, 2024
@ncoghlan ncoghlan changed the title Bug: --only-binary :all: should be passed when locking environments Bug: --only-binary :all: should be set when locking environments Dec 18, 2024
@ncoghlan
Copy link
Collaborator Author

Based on https://docs.astral.sh/uv/configuration/files/, I think a potential workaround may be to create a uv.toml file alongside venvstacks.toml, containing the text:

[pip]
only-binary=":all:"

(I haven't actually tested that, though, it's just theoretical based on reading the uv configuration docs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant