Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated warning when doing pnpm install #49

Open
skull8888888 opened this issue Oct 16, 2024 · 4 comments
Open

Remove deprecated warning when doing pnpm install #49

skull8888888 opened this issue Oct 16, 2024 · 4 comments
Assignees
Labels
frontend Requires work in the frontend package

Comments

@skull8888888
Copy link
Collaborator

Basically solve this
Screenshot 2024-10-15 at 7 53 00 PM

@skull8888888 skull8888888 added the good first issue Good for newcomers label Oct 16, 2024
@Banh983
Copy link

Banh983 commented Oct 16, 2024

Hi there! i would love to see if i can contribute anything for solving your problem, can you assgin it to me.

@Banh983
Copy link

Banh983 commented Oct 16, 2024

I think that some of your package needed update to work. And the [email protected], like in your image suggest you should install the @eslint/config-array instead. If those step not work feel free to ask

@dinmukhamedm dinmukhamedm added the frontend Requires work in the frontend package label Oct 18, 2024
@dinmukhamedm
Copy link
Member

Right, I had a quick look, we depend on most deprecated packages through eslint@8, which has been deprecated for a few months now. However, Next does not work with eslint@9, see vercel/next.js#64409 (comment). In [#55] I am removing one more dependency (react-query, now part of @tanstack and apparently unused) that brought some of the deprecated ones transitively.

But other than that, we'll just have to wait for Next 15 release.

@dinmukhamedm
Copy link
Member

^ Now that React 19 is finally stable, I will attempt the Next 15 upgrade within the following couple weeks (assuming all conflicting dependencies such as some of shadcn and recharts quickly upgrade).

Good side effect is that instrumentation.ts is also stable from Next 15.

@dinmukhamedm dinmukhamedm removed the good first issue Good for newcomers label Dec 6, 2024
@dinmukhamedm dinmukhamedm self-assigned this Dec 6, 2024
@dinmukhamedm dinmukhamedm mentioned this issue Dec 14, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Requires work in the frontend package
Projects
None yet
Development

No branches or pull requests

3 participants