Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "presets" to Datatable component #101

Open
skull8888888 opened this issue Oct 27, 2024 · 5 comments
Open

Add "presets" to Datatable component #101

skull8888888 opened this issue Oct 27, 2024 · 5 comments
Assignees
Labels
frontend Requires work in the frontend package UI UX

Comments

@skull8888888
Copy link
Collaborator

In Datatable component we have filters. It is really useful to save presets of this filters in the local storage so that they can be applied with one click. For instance in the traces, filter on the certain span paths can be quite handy preset.

@skull8888888 skull8888888 added frontend Requires work in the frontend package UI UX labels Oct 27, 2024
@lucky29-git
Copy link
Contributor

Hey @skull8888888, can you provide more detail on it?
I would love to work on this.
@dinmukhamedm Can I work on this?

@dinmukhamedm
Copy link
Member

@lucky29-git go for it!

So, to provide more context, currently the datatable filters (used in traces, sessions, and spans views) are stored as URL params under the key filter. It is a stringified array of json filters, where each has keys column, operator and value. We would like to add an ability for users to store a certain filter combination as a preset. Each preset must have a name. The presets must be saved in the localStorage and can be retrieved using something like a Select or a ComboBox component.

Example user flow:

  1. Go to spans view in the traces page
  2. Filter spans by path = my_agent.anthropic.chat and latency > 1.
  3. Click save as preset. In the appearing dialog/pop-up, name the preset something like anthropic slower than 1s.
  4. Go elsewhere in the platform
  5. Come back to the spans view
  6. Select anthropic slower than 1s from the available presets
  7. Laminar fills in the URL param filters with the saved value and shows the filtered data

To have some data for (2) you might need to observe some code and send it to localhost at grpc_port = 8001. Read more in our docs

@lucky29-git
Copy link
Contributor

Thanks @dinmukhamedm I will onto it, will reach out to you if needed any help.

@sarthakvijayvargiya
Copy link
Contributor

hi @lucky29-git Are you working on this? If not Please let me know.

@lucky29-git
Copy link
Contributor

Hi @sarthakvijayvargiya, I'll work on this
Just needed some time I'm in the middle of my exams right now.
Will let you know if needed any help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Requires work in the frontend package UI UX
Projects
None yet
Development

No branches or pull requests

4 participants