Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keypoint index class #1

Open
lmmx opened this issue Apr 23, 2021 · 0 comments
Open

Keypoint index class #1

lmmx opened this issue Apr 23, 2021 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@lmmx
Copy link
Owner

lmmx commented Apr 23, 2021

N.B. — the keypoints.py module is only used by the optimise module

make_keypoint_index should clearly be a KeypointIndex class __init__ method, and project_keypoints should be a project method, removing the index passing as 2nd argument.

  • This will probably extend to the inner function objective within optimise_params?

Additionally, draw_correspondences doesn’t belong in optimize, since it is called on the keypoint index and built on top of in the same way this should be another method of the KeypointIndex class, combined with debug_show.

  • Since this is a debugging util, put it in debug_utils/keypoint_debug.py
@lmmx lmmx added the enhancement New feature or request label Apr 23, 2021
@lmmx lmmx self-assigned this Sep 8, 2024
@lmmx lmmx moved this to 🔮 Future in Page Dewarp Release Planner Sep 8, 2024
@lmmx lmmx moved this from 🔮 Future to 💡 Idea in Page Dewarp Release Planner Sep 8, 2024
@lmmx lmmx moved this to 🐣 Hatching in Planner Sep 10, 2024
@lmmx lmmx moved this from 🐣 Hatching to 🔙 Backlog in Planner Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: 💡 Idea
Status: 📚 Shelved
Development

No branches or pull requests

1 participant