You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
N.B. — the keypoints.py module is only used by the optimise module
make_keypoint_index should clearly be a KeypointIndex class __init__ method, and project_keypoints should be a project method, removing the index passing as 2nd argument.
This will probably extend to the inner function objective within optimise_params?
Additionally, draw_correspondences doesn’t belong in optimize, since it is called on the keypoint index and built on top of in the same way this should be another method of the KeypointIndex class, combined with debug_show.
Since this is a debugging util, put it in debug_utils/keypoint_debug.py
The text was updated successfully, but these errors were encountered:
make_keypoint_index
should clearly be aKeypointIndex
class__init__
method, andproject_keypoints
should be aproject
method, removing the index passing as 2nd argument.objective
withinoptimise_params
?Additionally,
draw_correspondences
doesn’t belong inoptimize
, since it is called on the keypoint index and built on top of in the same way this should be another method of theKeypointIndex
class, combined withdebug_show
.debug_utils/keypoint_debug.py
The text was updated successfully, but these errors were encountered: