Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(web): Introduce Toast JavaScript plugin #DS-1115 #1305

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Feat(web): Introduce Toast JavaScript plugin #DS-1115 #1305

merged 2 commits into from
Mar 12, 2024

Conversation

adamkudrna
Copy link
Contributor

@adamkudrna adamkudrna commented Mar 5, 2024 •
edited
Loading

Description

Basic JS plugin to show and hide toasts that are already present in the DOM.

Additional context

Issue reference

https://jira.almacareer.tech/browse/DS-1115

@adamkudrna adamkudrna self-assigned this Mar 5, 2024
@github-actions github-actions bot added the feature New feature or request label Mar 5, 2024
@netlify Netlify
Copy link

netlify bot commented Mar 5, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit 728a783
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/65f035e22ac9e60008943484
😎 Deploy Preview https://deploy-preview-1305--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Mar 5, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit 728a783
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/65f035e22ac9e60008943488

@netlify Netlify
Copy link

netlify bot commented Mar 5, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-react ready!

Name Link
🔨 Latest commit 728a783
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/65f035e2f5a4210008aeb4b5
😎 Deploy Preview https://deploy-preview-1305--spirit-design-system-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Mar 5, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-demo ready!

Name Link
🔨 Latest commit 728a783
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/65f036308703780008ef071e
😎 Deploy Preview https://deploy-preview-1305--spirit-design-system-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

Coverage Status

coverage: 68.585% (-27.8%) from 96.371%
when pulling 19f440b on feature/web-toast-js-plugin
into 2e394dc on main.

@coveralls
Copy link

coveralls commented Mar 5, 2024 •
edited
Loading

Coverage Status

coverage: 80.155% (-0.4%) from 80.524%
when pulling 728a783 on feature/web-toast-js-plugin
into 3b9499d on main.

@pavelklibani pavelklibani force-pushed the feature/web-toast-js-plugin branch from 31d2a51 to c026ed5 Compare March 6, 2024 20:33
@adamkudrna adamkudrna marked this pull request as ready for review March 7, 2024 16:04
@adamkudrna adamkudrna requested review from crishpeen, pavelklibani and a team as code owners March 7, 2024 16:04
@adamkudrna adamkudrna requested a review from literat March 7, 2024 16:04
pavelklibani
pavelklibani approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@pavelklibani pavelklibani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work with the javascript! 👍

literat
literat approved these changes Mar 8, 2024
View reviewed changes
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few suggestions for a little refactor but otherwise it is looking good. :-)

@pavelklibani pavelklibani force-pushed the feature/web-toast-js-plugin branch from 5b37080 to cb79b50 Compare March 11, 2024 10:55
crishpeen
crishpeen approved these changes Mar 11, 2024
View reviewed changes
Copy link
Member

@crishpeen crishpeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

We might want to merge this into integration branch as this should update visual tests as well.

packages/web/src/scss/components/Toast/README.md Outdated Show resolved Hide resolved
packages/web/src/scss/components/Toast/README.md Outdated Show resolved Hide resolved
packages/web/src/js/constants.ts Show resolved Hide resolved
@adamkudrna adamkudrna force-pushed the feature/web-toast-js-plugin branch from cb79b50 to 728a783 Compare March 12, 2024 11:00
@adamkudrna adamkudrna merged commit 2d63d05 into main Mar 12, 2024
29 checks passed
@adamkudrna adamkudrna deleted the feature/web-toast-js-plugin branch March 12, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelklibani pavelklibani pavelklibani approved these changes

@crishpeen crishpeen crishpeen approved these changes

@literat literat literat approved these changes

Assignees

@adamkudrna adamkudrna

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@adamkudrna @coveralls @literat @crishpeen @pavelklibani