Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs(web): List Deprecations in the web package #DS-1043 #1301

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Docs(web): List Deprecations in the web package #DS-1043 #1301

merged 1 commit into from
Mar 12, 2024

Conversation

crishpeen
Copy link
Member

Description

Additional context

Issue reference

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Feb 29, 2024
@netlify Netlify
Copy link

netlify bot commented Feb 29, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit 0320825
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/65efc8b8bcf59c000837432a

@crishpeen crishpeen force-pushed the docs/web-deprecations branch from bad73fc to 8fade59 Compare February 29, 2024 15:27
@netlify Netlify
Copy link

netlify bot commented Feb 29, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-react ready!

Name Link
🔨 Latest commit 0320825
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/65efc8b803a8680008fcd7ea
😎 Deploy Preview https://deploy-preview-1301--spirit-design-system-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Feb 29, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-demo canceled.

Name Link
🔨 Latest commit 0320825
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/65efc8b86fc4720008a2d525

@netlify Netlify
Copy link

netlify bot commented Feb 29, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit 0320825
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/65efc8b8a3a7b50008f80fa6
😎 Deploy Preview https://deploy-preview-1301--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Feb 29, 2024 •
edited
Loading

Coverage Status

coverage: 80.078% (-16.3%) from 96.371%
when pulling 0320825 on docs/web-deprecations
into 67e52f8 on main.

@crishpeen crishpeen force-pushed the docs/web-deprecations branch from 8fade59 to f763efb Compare March 4, 2024 15:12
literat
literat approved these changes Mar 4, 2024
View reviewed changes
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👍

@literat
Copy link
Collaborator

literat commented Mar 4, 2024

Btw, should there be a root DEPRECATIONS file as we have the MIGRATION files that serve as a signpost?

@crishpeen
Copy link
Member Author

Btw, should there be a root DEPRECATIONS file as we have the MIGRATION files that serve as a signpost?

Yep, why not:)

adamkudrna
adamkudrna reviewed Mar 5, 2024
View reviewed changes
packages/web/DEPRECATIONS-v2.md Outdated Show resolved Hide resolved
packages/web/DEPRECATIONS-v2.md Outdated Show resolved Hide resolved
packages/web/DEPRECATIONS-v2.md Outdated Show resolved Hide resolved
@literat
Copy link
Collaborator

literat commented Mar 5, 2024

Btw, should there be a root DEPRECATIONS file as we have the MIGRATION files that serve as a signpost?

Yep, why not:)

Can I understand that you add it to this PR?

@crishpeen crishpeen force-pushed the docs/web-deprecations branch from f763efb to 6e78671 Compare March 5, 2024 12:51
@crishpeen crishpeen requested a review from literat March 6, 2024 16:59
literat
literat reviewed Mar 6, 2024
View reviewed changes
DEPRECATIONS-v2.md Outdated Show resolved Hide resolved
adamkudrna
adamkudrna reviewed Mar 7, 2024
View reviewed changes
Copy link
Contributor

@adamkudrna adamkudrna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the placements are still mixed a bit 🙂. Anyway, I think the first two placement migrations can be merged into one so users don't change the same thing twice. Dropdown combined classes can remain as they are.

DEPRECATIONS-v2.md Show resolved Hide resolved
DEPRECATIONS-v2.md Show resolved Hide resolved
packages/web/DEPRECATIONS-v2.md Outdated Show resolved Hide resolved
packages/web/DEPRECATIONS-v2.md Outdated Show resolved Hide resolved
@crishpeen crishpeen force-pushed the docs/web-deprecations branch from 6e78671 to 0320825 Compare March 12, 2024 03:15
@crishpeen crishpeen merged commit 3b9499d into main Mar 12, 2024
29 checks passed
@crishpeen crishpeen deleted the docs/web-deprecations branch March 12, 2024 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamkudrna adamkudrna adamkudrna left review comments

@literat literat literat approved these changes

@pavelklibani pavelklibani pavelklibani approved these changes

Assignees

@crishpeen crishpeen

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@crishpeen @coveralls @literat @adamkudrna @pavelklibani