From 4ba8887535f6083f04f0f37881706a09568250fd Mon Sep 17 00:00:00 2001 From: Adam Kudrna Date: Tue, 13 Feb 2024 13:02:53 +0100 Subject: [PATCH] Docs(web): Fix Sass implementation notes --- packages/web-react/src/components/Modal/README.md | 3 +-- packages/web-twig/src/Resources/components/Modal/README.md | 3 +-- packages/web/src/scss/components/Modal/_Modal.scss | 6 +++--- 3 files changed, 5 insertions(+), 7 deletions(-) diff --git a/packages/web-react/src/components/Modal/README.md b/packages/web-react/src/components/Modal/README.md index 32cabc6f06..5ba6651b2d 100644 --- a/packages/web-react/src/components/Modal/README.md +++ b/packages/web-react/src/components/Modal/README.md @@ -318,8 +318,7 @@ content is longer than user's viewport. #### ⚠️ DEPRECATION NOTICE The `isScrollable` prop will be set to `false` by default in the next major release and the ModalDialog will be made -non-scrollable by default. It will be possible to re-enable the inside scrolling by setting the -`isScrollable` boolean prop. +non-scrollable by default. It will be possible to re-enable the inside scrolling by adding the `isScrollable` prop. ## Stacking Modals diff --git a/packages/web-twig/src/Resources/components/Modal/README.md b/packages/web-twig/src/Resources/components/Modal/README.md index 5dd9d0c85f..f9d8ea740b 100644 --- a/packages/web-twig/src/Resources/components/Modal/README.md +++ b/packages/web-twig/src/Resources/components/Modal/README.md @@ -323,8 +323,7 @@ content is longer than user's viewport. #### ⚠️ DEPRECATION NOTICE The `isScrollable` prop will be set to `false` by default in the next major release and the ModalDialog will be made -non-scrollable by default. It will be possible to re-enable the inside scrolling by setting the -`isScrollable` prop to `true` explicitly. +non-scrollable by default. It will be possible to re-enable the inside scrolling by adding the `isScrollable`. ## Stacking Modals diff --git a/packages/web/src/scss/components/Modal/_Modal.scss b/packages/web/src/scss/components/Modal/_Modal.scss index a2af9d2200..9698309e37 100644 --- a/packages/web/src/scss/components/Modal/_Modal.scss +++ b/packages/web/src/scss/components/Modal/_Modal.scss @@ -1,8 +1,8 @@ // 1. In order to be transitioned, the visibility of the dialog is controlled through `opacity` and `visibility` // properties instead of the default `display`. // 2. Simply use Modal background color instead of `::backdrop` to make fading possible. (A pseudo-element cannot be -// used because it covers the scrollbar of the ModalDialog with the inside scrolling turned off.) -// 3. Use background gradient to prevent background from flickering in Safari. +// used because it covers the scrollbar of the ModalDialog when the inside scrolling is turned off.) +// 3. Use background gradient to prevent background from flickering during transition in Safari. // 4. Clip overflow during transition of the docked variant on mobile screens. // 5. Allow scrolling through the modal. Has no effect unless the modal is taller than the viewport. // 6. Restore text selection after `all: unset`. @@ -21,7 +21,7 @@ display: flex; // 1. padding-block: theme.$padding-y; overflow: hidden; // 4. - background: linear-gradient(#{theme.$backdrop-background-color}, #{theme.$backdrop-background-color}); // 8. + background: linear-gradient(#{theme.$backdrop-background-color}, #{theme.$backdrop-background-color}); // 2., 3. visibility: hidden; // 1. opacity: 0; // 1. pointer-events: none; // 1.