Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sanitizers] Improve size of blame lists of slow builders #310

Open
vitalybuka opened this issue Nov 18, 2024 · 2 comments
Open

[sanitizers] Improve size of blame lists of slow builders #310

vitalybuka opened this issue Nov 18, 2024 · 2 comments
Assignees

Comments

@vitalybuka
Copy link
Contributor

vitalybuka commented Nov 18, 2024

According to llvm/llvm-project#115361 (comment) unrelated steps of current bootstrap bots unnecessarily spam libc++ patches.

@vitalybuka
Copy link
Contributor Author

This will not be helpfull.
The reason is that those bots are quite slow 3-4 hours.
If libc++ patch gets into blame list with another bad patch, it will be notified, regardless we run or not check-cxx.

The problem is make them faster in general.
They run on quite fast hardware.

Without dropping test coverage, or significantly increasing number of VMs, I don't see good way to have blame list small.

@vitalybuka vitalybuka changed the title [sanitizers] Extract check-cxx into a separate builder [sanitizers] Improve size of blame lists of slow builders Nov 19, 2024
@vitalybuka vitalybuka reopened this Nov 19, 2024
@asb
Copy link
Contributor

asb commented Nov 19, 2024

This will not be helpfull. The reason is that those bots are quite slow 3-4 hours. If libc++ patch gets into blame list with another bad patch, it will be notified, regardless we run or not check-cxx.

The problem is make them faster in general. They run on quite fast hardware.

Without dropping test coverage, or significantly increasing number of VMs, I don't see good way to have blame list small.

I think the solution is the "gatekeeper" idea that @gkistanova as mentioned before and I think had a prototype implementation at one point. Basically - only kick off a build on a slower builder once a faster builder has completed successfully. This reduces the chances of creating a delayed failure response for an issue that was already found and fixed through bots with a faster turnaround time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants