[AArch64][PAC][clang][ELF] Support PAuth ABI core info #85235
+274
−6
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| // REQUIRES: aarch64-registered-target | ||
|
There was a problem hiding this comment. Most clang/test/CodeGen tests don't need registered-target. You can check this by removing AArch64 from LLVM_TARGETS_TO_BUILD There was a problem hiding this comment. Ensured that it's not needed and deleted in 2fd8f66, thanks |
||
|
|
||
| // RUN: %clang --target=aarch64-linux -S -emit-llvm -o - \ | ||
|
There was a problem hiding this comment. We prefer There was a problem hiding this comment. Fixed, thanks, see fdb26a1 |
||
| // RUN: -fptrauth-intrinsics \ | ||
| // RUN: -fptrauth-calls \ | ||
| // RUN: -fptrauth-returns \ | ||
| // RUN: -fptrauth-auth-traps \ | ||
| // RUN: -fptrauth-vtable-pointer-address-discrimination \ | ||
| // RUN: -fptrauth-vtable-pointer-type-discrimination \ | ||
| // RUN: -fptrauth-init-fini %s | \ | ||
| // RUN: FileCheck %s --check-prefix=ALL | ||
|
|
||
| // RUN: %clang --target=aarch64-linux -S -emit-llvm -o - \ | ||
| // RUN: -fptrauth-intrinsics %s | FileCheck %s --check-prefix=INTRIN | ||
|
|
||
| // RUN: %clang --target=aarch64-linux -S -emit-llvm -o - \ | ||
| // RUN: -fptrauth-calls %s | FileCheck %s --check-prefix=CALL | ||
|
|
||
| // RUN: %clang --target=aarch64-linux -S -emit-llvm -o - \ | ||
| // RUN: -fptrauth-returns %s | FileCheck %s --check-prefix=RET | ||
|
|
||
| // RUN: %clang --target=aarch64-linux -S -emit-llvm -o - \ | ||
| // RUN: -fptrauth-auth-traps %s | FileCheck %s --check-prefix=TRAP | ||
|
|
||
| // RUN: %clang --target=aarch64-linux -S -emit-llvm -o - \ | ||
| // RUN: -fptrauth-calls -fptrauth-vtable-pointer-address-discrimination %s | \ | ||
| // RUN: FileCheck %s --check-prefix=VPTRADDR | ||
|
|
||
| // RUN: %clang --target=aarch64-linux -S -emit-llvm -o - \ | ||
| // RUN: -fptrauth-calls -fptrauth-vtable-pointer-type-discrimination %s | \ | ||
| // RUN: FileCheck %s --check-prefix=VPTRTYPE | ||
|
|
||
| // RUN: %clang --target=aarch64-linux -S -emit-llvm -o - \ | ||
| // RUN: -fptrauth-calls -fptrauth-init-fini %s | \ | ||
| // RUN: FileCheck %s --check-prefix=INITFINI | ||
|
|
||
| // ALL: !{i32 1, !"aarch64-elf-pauthabi-platform", i32 268435458} | ||
| // ALL: !{i32 1, !"aarch64-elf-pauthabi-version", i32 127} | ||
|
|
||
| // INTRIN: !{i32 1, !"aarch64-elf-pauthabi-platform", i32 268435458} | ||
| // INTRIN: !{i32 1, !"aarch64-elf-pauthabi-version", i32 1} | ||
|
|
||
| // CALL: !{i32 1, !"aarch64-elf-pauthabi-platform", i32 268435458} | ||
| // CALL: !{i32 1, !"aarch64-elf-pauthabi-version", i32 2} | ||
|
|
||
| // RET: !{i32 1, !"aarch64-elf-pauthabi-platform", i32 268435458} | ||
| // RET: !{i32 1, !"aarch64-elf-pauthabi-version", i32 4} | ||
|
|
||
| // TRAP: !{i32 1, !"aarch64-elf-pauthabi-platform", i32 268435458} | ||
| // TRAP: !{i32 1, !"aarch64-elf-pauthabi-version", i32 8} | ||
|
|
||
| // VPTRADDR: !{i32 1, !"aarch64-elf-pauthabi-platform", i32 268435458} | ||
| // VPTRADDR: !{i32 1, !"aarch64-elf-pauthabi-version", i32 18} | ||
|
|
||
| // VPTRTYPE: !{i32 1, !"aarch64-elf-pauthabi-platform", i32 268435458} | ||
| // VPTRTYPE: !{i32 1, !"aarch64-elf-pauthabi-version", i32 34} | ||
|
|
||
| // INITFINI: !{i32 1, !"aarch64-elf-pauthabi-platform", i32 268435458} | ||
| // INITFINI: !{i32 1, !"aarch64-elf-pauthabi-version", i32 66} | ||
|
|
||
| void foo() {} | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| // Check that we can manually enable specific ptrauth features. | ||
|
There was a problem hiding this comment. aarch64-ptrauth.c is more conventional for such target-specific features |
||
|
|
||
| // RUN: %clang --target=aarch64 -c %s -### 2>&1 | FileCheck %s --check-prefix NONE | ||
| // NONE: "-cc1" | ||
| // NONE-NOT: "-fptrauth-intrinsics" | ||
|
There was a problem hiding this comment.
There was a problem hiding this comment. Fixed, thanks, see 4fd37cf |
||
| // NONE-NOT: "-fptrauth-calls" | ||
| // NONE-NOT: "-fptrauth-returns" | ||
| // NONE-NOT: "-fptrauth-auth-traps" | ||
| // NONE-NOT: "-fptrauth-vtable-pointer-address-discrimination" | ||
| // NONE-NOT: "-fptrauth-vtable-pointer-type-discrimination" | ||
| // NONE-NOT: "-fptrauth-init-fini" | ||
|
|
||
| // RUN: %clang --target=aarch64 -fptrauth-intrinsics -c %s -### 2>&1 | FileCheck %s --check-prefix INTRIN | ||
| // INTRIN: "-cc1"{{.*}} "-fptrauth-intrinsics" | ||
|
|
||
| // RUN: %clang --target=aarch64 -fptrauth-calls -c %s -### 2>&1 | FileCheck %s --check-prefix CALL | ||
| // CALL: "-cc1"{{.*}} "-fptrauth-calls" | ||
|
|
||
| // RUN: %clang --target=aarch64 -fptrauth-returns -c %s -### 2>&1 | FileCheck %s --check-prefix RETURN | ||
| // RETURN: "-cc1"{{.*}} "-fptrauth-returns" | ||
|
|
||
| // RUN: %clang --target=aarch64 -fptrauth-auth-traps -c %s -### 2>&1 | FileCheck %s --check-prefix TRAPS | ||
| // TRAPS: "-cc1"{{.*}} "-fptrauth-auth-traps" | ||
|
|
||
| // RUN: %clang --target=aarch64 -fptrauth-vtable-pointer-address-discrimination -c %s -### 2>&1 | FileCheck %s --check-prefix VPTR_ADDR_DISCR | ||
| // VPTR_ADDR_DISCR: "-cc1"{{.*}} "-fptrauth-vtable-pointer-address-discrimination" | ||
|
|
||
| // RUN: %clang --target=aarch64 -fptrauth-vtable-pointer-type-discrimination -c %s -### 2>&1 | FileCheck %s --check-prefix VPTR_TYPE_DISCR | ||
| // VPTR_TYPE_DISCR: "-cc1"{{.*}} "-fptrauth-vtable-pointer-type-discrimination" | ||
|
|
||
| // RUN: %clang --target=aarch64 -fptrauth-init-fini -c %s -### 2>&1 | FileCheck %s --check-prefix INITFINI | ||
| // INITFINI: "-cc1"{{.*}} "-fptrauth-init-fini" | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linux implies ELF. You can remove
getTriple().isOSBinFormatELF()There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, but I'll leave an assertion against ELF here. Theoretically, we might have non-ELF binary format on Linux, while the Linux itself seems to have deprecated COFF and a.out support and llvm does not seem to support them as well. This assertion makes sense to me since (a) it makes things clear that we want to check both Linux and ELF (b) this will notify us if in future we have binary formats other than ELF supported on Linux.
See 37a4d9d