Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use alias in LLVM::GlobalOp lowering once LLVM IR Dialect has it #1065

Open
bcardosolopes opened this issue Nov 6, 2024 · 4 comments
Open

Comments

@bcardosolopes
Copy link
Member

While working at this, I noticed that LLVM IR dialect GlobalOp does not yet support alias, so we cannot yet lower this information down. Let me file another issue for that.

For now, I'm going to emit a global but not yet set the alias, won't be much better than what we currently have but it's a first step - later on we can just set the alias when MLIR support comes.

Originally posted by @bcardosolopes in #1048 (comment)

@smeenai
Copy link
Collaborator

smeenai commented Nov 6, 2024

Shouldn't we file this upstream?

@bcardosolopes bcardosolopes changed the title LLVM IR Dialect is missing a alias attribute on LLVM::GlobalOp Use alias in LLVM::GlobalOp lowering once LLVM IR Dialect has it Nov 6, 2024
@bcardosolopes
Copy link
Member Author

bcardosolopes commented Nov 6, 2024

Mostly worried about tracking what we need to do in CIR once this lands, retitle to be more clear. We should file this upstream against MLIR for sure, but since @thevinster might grab this I'll let him decide if he wants to produce a PR or an issue (or both).

@bcardosolopes
Copy link
Member Author

Even harder than what it seems, I also hit #1083 while trying to fix this. Once we get unblocked, we need to look at clang/test/CIR/CodeGen/virtual-destructor-calls.cpp and fix the tests accordingly.

@bcardosolopes
Copy link
Member Author

Report MLIR upstream in llvm/llvm-project#115390

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants