Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix PDF data source link in Overview #169

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Conversation

jhony112
Copy link
Contributor

DataSources Pdf link currently points to a wrong url, this fixes the href reference

Description

Old url on overview page for DataSources points to components/data-sources/pdf-file should be : components/data-sources/pdf

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (does not change functionality, e.g. code style improvements, linting)
  • Documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new tsc or eslint warnings
  • I have ran tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • My changes do not result in new npm audit errors

@adhityan
Copy link
Collaborator

Thank you for the fix.

Copy link

nx-cloud bot commented Nov 20, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 90288dc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@adhityan
Copy link
Collaborator

The project follows conventional commit standards. Could you amend your commit messages to follow this pattern? Read more here - https://www.conventionalcommits.org/en/v1.0.0

I think in your case, you need to remove the space between the : and docs. Sorry to have this enforced but all the other build tools work with this standard.

@jhony112 jhony112 changed the title docs: fix PDF data source link in Overview docs:fix PDF data source link in Overview Nov 20, 2024
@jhony112 jhony112 changed the title docs:fix PDF data source link in Overview docs: fix PDF data source link in Overview Nov 20, 2024
@jhony112
Copy link
Contributor Author

@adhityan should be fixed now

@adhityan
Copy link
Collaborator

Great. LGTM.

@adhityan adhityan merged commit 49a0675 into llm-tools:main Nov 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants