Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Echo Cancellation on macOS #439

Open
keyur2maru opened this issue Nov 20, 2024 · 0 comments
Open

[Feature Request] Echo Cancellation on macOS #439

keyur2maru opened this issue Nov 20, 2024 · 0 comments

Comments

@keyur2maru
Copy link

Thank you for developing this package! The echo cancellation feature works flawlessly on iOS, Android, and Web. However, I noticed that it is not supported on macOS or Windows. For macOS, According to the AVAudioIONode documentation, the setVoiceProcessingEnabled method is supported on macOS 10.15 and later. If this documentation is accurate, is there another reason why echo cancellation is not supported on macOS?

To troubleshoot, I tried removing the if #available(iOS 13.0, *) and #if os(iOS) checks in the record_darwin/darwin/Classes/delegate/RecorderStreamDelegate.swift file, but this didn’t resolve the issue.

If needed, I’ve shared the full diff of my changes here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant