Fix sort_by failing if a tag does not exist in TAG_ORDER #82
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an error if another tag is added to a model parsed by SwaggerYard eg.
YARD::Tags::Library.define_tag('MuCustomTag', :my_custom_tag)
We have custom tags on our models that would cause warning messages when hit by
::Yard.parse
. To suppress these warning messages, we define these custom tags in yard like so:In doing so, however, it causes
spec = SwaggerYard::OpenAPI.new.to_h
to error out at the line changed in this PR since the custom tag does not exist inTAG_ORDER
.Since the case statement following the fixed line is a no-op on custom tags we can simply set the sort value of those tags to 0 to avoid
nil
comparisons and keep them in thesorted_tags
array.Command run (our custom rake task to generate OpenAPI docs):
time bundle exec rails swagger_yard:generate --trace
Error:
This duplicates #81 because I needed to change the downstream branch.