Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

O images loaded from unreliable source #202

Open
0xcadams opened this issue Nov 28, 2022 · 3 comments
Open

O images loaded from unreliable source #202

0xcadams opened this issue Nov 28, 2022 · 3 comments
Assignees
Labels
type: bug Something isn't working

Comments

@0xcadams
Copy link
Contributor

0xcadams commented Nov 28, 2022

The current ENS image loading comes from https://metadata.ens.domains/mainnet/avatar/, which has caused issues in the past. We should load directly from IPFS/URL (or a better cache source) and avoid reliance on this service.

@0xcadams 0xcadams added the type: bug Something isn't working label Nov 28, 2022
@0xcadams 0xcadams self-assigned this Nov 28, 2022
@0xcadams 0xcadams changed the title O images not loading w/ 429 response code O images loaded from unreliable source Dec 1, 2022
@rickstaa
Copy link
Member

Hi @0xcadams, I wanted to address the long load times for some avatars on the Explorer. Can you confirm if this was partly addressed in your commit b34f68f? Specifically, I'm referring to the changes in [name].tsx.

@0xcadams
Copy link
Contributor Author

Yes, this was addressed, and we cache image responses heavily so this should be partially resolved.

@JJassonn69
Copy link

Yes, this was addressed, and we cache image responses heavily so this should be partially resolved.

How long is the caching window?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants