Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up: pass the URL object as we are already parsing it #860

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

mjh1
Copy link
Contributor

@mjh1 mjh1 commented Sep 12, 2023

No description provided.

@mjh1 mjh1 requested a review from leszko September 12, 2023 15:13
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #860 (40783b8) into main (7fc5223) will increase coverage by 0.01756%.
Report is 1 commits behind head on main.
The diff coverage is 60.00000%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #860         +/-   ##
===================================================
+ Coverage   51.66228%   51.67984%   +0.01756%     
===================================================
  Files             63          63                 
  Lines           6076        6072          -4     
===================================================
- Hits            3139        3138          -1     
+ Misses          2685        2683          -2     
+ Partials         252         251          -1     
Files Changed Coverage Δ
pipeline/coordinator.go 80.61466% <50.00000%> (ø)
pipeline/ffmpeg.go 33.20000% <100.00000%> (+0.12913%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fc5223...40783b8. Read the comment docs.

Files Changed Coverage Δ
pipeline/coordinator.go 80.61466% <50.00000%> (ø)
pipeline/ffmpeg.go 33.20000% <100.00000%> (+0.12913%) ⬆️

@mjh1 mjh1 merged commit 0794951 into main Sep 13, 2023
@mjh1 mjh1 deleted the mh/storj-source branch September 13, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants