transmux: use smaller chunks when concatenating long list of files #1212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When very large files are ingested, the segmented file list can be a very long list. This list of files are passed to ffmpeg commands which will may fail with a 'command: arg list too long' error (linux error and not ffmpeg error). This happens because the arg length exceeds the MAX_ARG limit which varies from kernel to kernel. To workaround this issue, we break down the list into smaller chunks and then concat those chunks to get the final concatenated file.
thomshutt
approved these changes
Apr 9, 2024
|
I think this looks good, but I'm having trouble envisioning the final ffmpeg comand - could you throw a before / after example in here please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When very large files are ingested, the segmented file list can be a very long list. This list of files are passed to ffmpeg commands which will may fail with a 'command: arg list too long' error (linux error and not ffmpeg error). This happens because the arg length exceeds the MAX_ARG limit which varies from kernel to kernel. To workaround this issue, we break down the list into smaller chunks and then concat those chunks to get the final concatenated file.
TODO: test on staging with a very large file