Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make IngressClassName configurable #75

Open
p4block opened this issue Jun 6, 2023 · 2 comments
Open

Make IngressClassName configurable #75

p4block opened this issue Jun 6, 2023 · 2 comments

Comments

@p4block
Copy link

p4block commented Jun 6, 2023

https://github.com/livekit/livekit-helm/blob/e68ba571d946c5d1fbd58d8dc46aceac62c5019b/livekit-server/templates/ingress.yaml#LL39C1-L39C1

It was quite unnerving to see Traefik not pick up the Ingress setup by the helmchart, but thankfully I discovered quickly that this is hardcoded.

(maybe I really shouldn't try to use another Ingress than nginx, but I didn't find anything in the docs to suggest issues)

@davidzhao
Copy link
Member

We haven't tested with any other Ingress types, but I'm open to it! Would you like to open a PR for this?

@p4block
Copy link
Author

p4block commented Jul 1, 2023

  {{- if eq .Values.loadBalancer.type "do" }}
  ingressClassName: nginx
  {{- end }}

What do you think would be a good way to sidestep this? First guess, checking against a "useDefaultIngressClass" default false that you set to true.

Right now on DO I point their LB with PROXY to all nodes running a daemonset Traefik that does the actual balancing between the pods.

I'm thinking of just setting up nginx and getting another LB that more suits your default intended usecase. I'm worried about excessive inter-cluster network usage, although afaik the bulk of the comms are p2p or through the dedicated TURN LB so it shouldn't be a problem.

Coincidentally our previous production setup simply had a TLS-terminating TCP LB point to LiveKit directly with no Ingress... Need to think about this, would love to hear your thoughts too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants