Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readiness probe must not be the same as the liveness one #116

Open
mykola-mokhnach-parloa opened this issue Nov 27, 2024 · 1 comment
Open

Comments

@mykola-mokhnach-parloa
Copy link

Currently both liveness and readiness probes in the chart are set to check the same endpoint, which is /.

This might not work as expected in case, for example, if we need to gracefully shutdown the service.
For the time range the pod is being gracefully shut down (e.g. it has already received SIGTERM, but terminationGracePeriodSeconds has not expired yet and the service itself is still running/cleaning up) I would expect the readiness probe to return an error, so no traffic is forwarded to the given pod, while the liveness probe must still return 200, thus preventing the pod from being killed and restarted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant