Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]Egress server continues capturing black images after video stops publishing #823

Open
leejiliang opened this issue Dec 11, 2024 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@leejiliang
Copy link

Describe the bug
When I send a timed screenshot request to the Egress server, I notice that the server continues to capture images even after the video stream stops publishing. However, the generated images are all completely black.

I would like to know if this is the intended behavior. Should the Egress server automatically stop capturing images when no video is being published? Alternatively, could you provide an API for developers to explicitly signal the Egress server to stop at an appropriate time?

Egress Version
docker hub image livekit/egress:latest

Egress Request
req := &livekit.RoomCompositeEgressRequest{} req.RoomName = "LOTUS-test-ljl" req.ImageOutputs = []*livekit.ImageOutput{ { CaptureInterval: 10, FilenamePrefix: "livekit/egress-image/", FilenameSuffix: livekit.ImageFileSuffix_IMAGE_SUFFIX_INDEX, Output: &livekit.ImageOutput_AliOSS{ AliOSS: &livekit.AliOSSUpload{ AccessKey: "LTxxxxxxxxSN", Secret: "xrFyyyyyyyyyibeEyvlU", Region: "cn-hangzhou", Endpoint: "https://oss-cn-hangzhou.aliyuncs.com", Bucket: "loxxxxxxco", }, }, }, } egress, err := EgressClient.StartRoomCompositeEgress(context.TODO(), req)

Additional context
black picture
LOTUS-test-ljl-2024-12-11T054417_00172

Logs
Post any relevant logs from the egress service here.

@leejiliang leejiliang added the bug Something isn't working label Dec 11, 2024
@mpisat
Copy link

mpisat commented Dec 12, 2024

egress generates video_test_src to ensure there is always video track available, so when you stop, it may be falling back to that. I'm not sure if this is the intended behavior but you can always stop egress when publisher stops.

@leejiliang
Copy link
Author

egress generates video_test_src to ensure there is always video track available, so when you stop, it may be falling back to that. I'm not sure if this is the intended behavior but you can always stop egress when publisher stops.

Egress is a server for every room in LiveKit. I can't stop it when a room stops publishing video; it should keep running always.

@mpisat
Copy link

mpisat commented Dec 13, 2024

I don’t mean to stop egress service. I mean stop egress track rtmp output with api call

@leejiliang
Copy link
Author

I don’t mean to stop egress service. I mean stop egress track rtmp output with api call

Is there an API that supports this operation? I couldn't find it in the documentation.

@mpisat
Copy link

mpisat commented Dec 13, 2024

I’m able to kill egress by id using lk cli tool so I’m sure there is an api for it.

@mpisat
Copy link

mpisat commented Dec 13, 2024

https://docs.livekit.io/home/egress/api/
check out StopEgress section @leejiliang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants