Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] The Google translate popup is visible in recordings #774

Closed
marc136 opened this issue Sep 12, 2024 · 1 comment
Closed

[BUG] The Google translate popup is visible in recordings #774

marc136 opened this issue Sep 12, 2024 · 1 comment
Assignees
@frostbyte73
Labels
bug Something isn't working

Comments

@marc136
Copy link

marc136 commented Sep 12, 2024 •
edited
Loading

Describe the bug
If I start a Room Composite Egress with a custom recorder template that does not use English as document language, the Chrome browser's translate popup is shown and it is also be part of a recording.

recording-with-translate.mp4

Egress Version
1.8.4

Additional context
To reproduce, you only need to change from <html lang="en"> to <html lang="de"> in the official template

After searching around and testing, we mitigated this problem by adding <meta name="google" content="notranslate" /> to the html head of our custom recorder template.

According to https://issues.chromium.org/issues/41347677#comment12 the flag --disable-features=TranslateUI should be used to start the headless browser, which is done as instructed in https://github.com/livekit/egress/blob/main/pkg/pipeline/source/web.go#L233
And even the old flag was added with #494 so it seems strange why it would not work.

Logs

2024-09-12T08:19:23.989Z	INFO	egress	server/server_rpc.go:71	request validated	{"nodeID": "NE_9EJdjEsEzMzB", "clusterID": "", "egressID": "EG_BxUc7R3Vm2AE", "requestType": "room_composite", "outputType": "file", "room": "1234", "request": {"RoomComposite":{"room_name":"1234","custom_base_url":"{internal}","Output":{"File":{"file_type":1,"filepath":"/out/recordings/20240912T081923.334295746Z-996328170.0.mp4","Output":null}},"Options":{"Advanced":{"width":1280,"height":720,"depth":24,"framerate":30,"audio_codec":2,"audio_bitrate":128,"audio_frequency":44100,"video_codec":2,"video_bitrate":240}}}}}
2024-09-12T08:19:24.082Z	DEBUG	egress	source/web.go:202	launching chrome	{"nodeID": "NE_9EJdjEsEzMzB", "handlerID": "EGH_cZ2aJi36eLDa", "clusterID": "", "egressID": "EG_BxUc7R3Vm2AE", "url": "http://ingressroutes?layout=&token=<...>&url=wss%3A%2F%2Flivekit.<...>", "sandbox": false, "insecure": true}
@marc136 marc136 added the bug Something isn't working label Sep 12, 2024
@davidzhao
Copy link
Member

thank you for the report. This is fixed in #775

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frostbyte73 frostbyte73

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@davidzhao @marc136 @frostbyte73