Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VoiceAssistantControlBar change device do not show correct selection. #1346

Open
tcper opened this issue Dec 6, 2024 · 0 comments
Open

VoiceAssistantControlBar change device do not show correct selection. #1346

tcper opened this issue Dec 6, 2024 · 0 comments

Comments

@tcper
Copy link

tcper commented Dec 6, 2024

Describe the bug

image
Change device, always show the first selection.

Reproduction

<LiveKitRoom
        connect={token !== undefined}
        token={token}
        serverUrl="wss://xxx"
        room={room}
      >
<VoiceAssistantControlBar controls={{ leave: false }} />
</LiveKitRoom>

Debug the code from livekit-client/livekit-react

Room.ts

try {
        success = (
          await Promise.all(tracks.map((t) => t.videoTrack?.setDeviceId(deviceConstraint)))
        ).every((val) => val === true);
      } catch (e) {
        this.options.videoCaptureDefaults!.deviceId = prevDeviceId;
        throw e;
      }

success variable always got false value,
make the later event emit not work

if (deviceHasChanged && success) {
      this.localParticipant.activeDeviceMap.set(kind, deviceId);
      this.emit(RoomEvent.ActiveDeviceChanged, kind, deviceId);
    }

Logs

No response

System Info

Model Name:	MacBook Air
  Model Identifier:	Mac14,2
  Model Number:	Z15W001ADCH/A
  Chip:	Apple M2
  Total Number of Cores:	8 (4 performance and 4 efficiency)
  Memory:	16 GB
  System Firmware Version:	11881.1.1
  OS Loader Version:	11881.1.1
  Serial Number (system):	RMGJXG0QJN
  Hardware UUID:	96DD2714-C497-5025-95DF-EEEE6A98706F
  Provisioning UDID:	00008112-000E20462631401E
  Activation Lock Status:	Enabled


Chrome

Severity

annoyance

Additional Information

No response

tcper added a commit to tcper/client-sdk-js that referenced this issue Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant