Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hanging up as a SIP participant message doesn't get committed to the chat_ctx #1170

Open
martin-purplefish opened this issue Dec 4, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@martin-purplefish
Copy link
Contributor

We're using the on_agent_message_committed to log the transcript to our backend.

The behavior we've noticed is that when the user hangs up, while the agent stops speaking, we don't get a final on_agent_message_committed - so that final cut off message doesn't appear in our own transcript.

To reproduce:

  1. Add callback handlers for on_agent_message_committed and on_agent_message_interrupted that log.
  2. Call the agent.
  3. Hang up the phone half way through.

The audio (at least on egress) will stop, but no callbacks will happen.

@martin-purplefish martin-purplefish added the bug Something isn't working label Dec 4, 2024
@martin-purplefish martin-purplefish changed the title Hanging up as a SIP participant message doesn't get committed to the log. Hanging up as a SIP participant message doesn't get committed to the chat_ctx Dec 4, 2024
@martin-purplefish
Copy link
Contributor Author

#1179 would be a fix.

@martin-purplefish
Copy link
Contributor Author

Also happens for if the candidate is speaking when they hang up (rare in practice) - their last message isn't committed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant