Skip to content
This repository has been archived by the owner on Sep 30, 2019. It is now read-only.

Incorrect $util.isNullOrEmpty check in appsynce-emulator #171

Open
cyberwombat opened this issue Sep 18, 2019 · 3 comments
Open

Incorrect $util.isNullOrEmpty check in appsynce-emulator #171

cyberwombat opened this issue Sep 18, 2019 · 3 comments

Comments

@cyberwombat
Copy link

Both of these methods return the opposite of expected in lib/util.js

isNullOrEmpty(value) {
    return !!value; // This checks that its NOT null
},
isNullOrBlank(value) {
    return !!value;  // Same here
},
@cbaron
Copy link
Contributor

cbaron commented Sep 18, 2019

@cyberwombat -- good catch. If you have the time, please submit a PR and we can merge this into master.

Also, this package has been incorporated into AWS's Amplify. If you're working on a new project, I highly suggest utilizing Amplify instead of this deprecated package.

@cyberwombat
Copy link
Author

@cbaron - am actually extending it to add pipeline for use in serverless offline. I looked at amplify but don't see how I can use it as a serverless offline emulator?

@cbaron
Copy link
Contributor

cbaron commented Sep 18, 2019

Check out this post: https://aws.amazon.com/blogs/aws/new-local-mocking-and-testing-with-the-amplify-cli/

Let me know if I can help, but also fee free to reach out to the Amplify team on Github!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants