Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slice initialization to avoid null response #4931

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

seedspirit
Copy link
Contributor

Proposed changes

In some APIs that retrieve multiple entities, if there are no entities that meet the conditions, the API returns null instead of an empty list. To ensure consistent response format, we modified the code to initialize empty slices before processing the results.

Before

null_apitokens null-projects

After

empty-list-apitokens empty-slice-projects

About Frontend

As frontend use optional chaining to safely handle null response(or not used in anywhere in case of projectStats), this change won't affect the frontend behaivor

APIToken-Frontend Project-Frontend image

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Signed-off-by: BoGyum Kim | 김보겸 <[email protected]>
@namkyu1999 namkyu1999 added the need-approvers-review Reminder label to the codeowners/maintainers for stale PRs that are more that 2 weeks old label Nov 15, 2024
Copy link
Member

@S-ayanide S-ayanide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@S-ayanide S-ayanide merged commit 5f0ea89 into litmuschaos:master Nov 22, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mentorship-kr need-approvers-review Reminder label to the codeowners/maintainers for stale PRs that are more that 2 weeks old
Projects
Development

Successfully merging this pull request may close these issues.

4 participants