New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When searching a product not in the system should throw a useful error. #13

Open

pedelman opened this issue Jun 24, 2014 · 1 comment

pedelman commented Jun 24, 2014

Currently when looking up a product upc or a text string in the product search API, when the product isn't found, you get an error like:

search_results.rb:20:in `initialize': undefined method `each' for nil:NilClass (NoMethodError)

Would be nice to handle this case in a more graceful manner.

The text was updated successfully, but these errors were encountered:

Contributor

ngan commented Jun 24, 2014

Hm...I think API use to return an empty array. Care to submit a PR?

peteroome mentioned this issue

Return an empty array when the API responds with nil for ["items"] in the search results. #23

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment