Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #177

Open
wants to merge 26 commits into
base: dev
Choose a base branch
from
Open

Dev #177

wants to merge 26 commits into from

Conversation

WhiteSevs
Copy link

No description provided.

@WhiteSevs
Copy link
Author

可以修复/实现以下issue
#144
#153

@WhiteSevs WhiteSevs changed the base branch from main to dev July 25, 2024 08:54
@martixy
Copy link

martixy commented Jul 26, 2024

@WhiteSevs Appreciate the work on #153

But are you sure it will work?
6f9fe45#diff-0036fffb54472a55085d5e4d2279c42d2d141b7726439c8dbbed768baa2fc3a8R311

Does filePath start with a slash?

Cuz the file URLs on windows I use are all with 3 slashes - file:///C:/... and you only add 2.

@WhiteSevs
Copy link
Author

@WhiteSevs Appreciate the work on #153

But are you sure it will work? 6f9fe45#diff-0036fffb54472a55085d5e4d2279c42d2d141b7726439c8dbbed768baa2fc3a8R311

Does filePath start with a slash?

Cuz the file URLs on windows I use are all with 3 slashes - file:///C:/... and you only add 2.

没问题的,file://可以正常使用,你可以试一下,我自己就设置成这样的
Clip_2024-07-26_23-03-56

@andywang425
Copy link
Contributor

3 slashes is a correct and standard way while most software are also compatible with 2 slashes. So it's just a minor problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants